Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console-logs] Expose LoggerProviderBuilder extension #4583

Merged
merged 3 commits into from
Jun 12, 2023
Merged

[console-logs] Expose LoggerProviderBuilder extension #4583

merged 3 commits into from
Jun 12, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 12, 2023 •
edited
Loading

Relates to #4433

Changes

  • Exposes the LoggerProviderBuilder.AddConsoleExporter extension

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team June 12, 2023 16:18
@CodeBlanch CodeBlanch mentioned this pull request Jun 12, 2023
Open
53 tasks
@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #4583 (ac3e8c0) into main (3274c43) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4583   +/-   ##
=======================================
  Coverage   85.10%   85.11%           
=======================================
  Files         320      320           
  Lines       12679    12679           
=======================================
+ Hits        10791    10792    +1     
+ Misses       1888     1887    -1
Impacted Files Coverage Δ
...porter.Console/ConsoleExporterLoggingExtensions.cs 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 09399d8 into open-telemetry:main Jun 12, 2023
@CodeBlanch CodeBlanch deleted the console-loggerproviderbuilderext-public branch June 12, 2023 17:59
@utpilla utpilla mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeBlanch @alanwest @vishweshbankwar